Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibility of specify different aria-label for Cards #5529

Closed
sandrodw3 opened this issue May 16, 2023 · 1 comment · Fixed by #5542
Closed

Possibility of specify different aria-label for Cards #5529

sandrodw3 opened this issue May 16, 2023 · 1 comment · Fixed by #5542
Assignees
@matuzalemsteles
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) rfc Similar to the RFC that are used in React.js, Ember.js, Gatsby.js and Rust, but to mark problems tha
Milestone
LPS-185488 Weekly...

Comments

@sandrodw3
Copy link
Member

Context

Hi guys! 😄 This is a follow-up of #5425.
In that issue, I asked for the possibility of adding an aria-label for all Cards component. As far as I could see, the fix has been adding as aria-label the same value we have for title. I think that in some cases, we need to add a different value for the aria-label, for example if we want to add extra info that the title does not have.

What is your proposal?

For that reason, I think it would be ideal to be able to specify the aria-label as a prop, something like titleAriaLabel, so we can give it a different value.

Example

I'm giving our case as example. For this card, the title says "Styles from Theme", but for the aria-label we would like to have "Styles from Theme (marked as default)". We could achieve that if the aria-label itself was a prop for Card components, as I suggested.

image

Please let me know your thoughts, thanks!
@sandrodw3 sandrodw3 added the rfc Similar to the RFC that are used in React.js, Ember.js, Gatsby.js and Rust, but to mark problems tha label May 16, 2023
@matuzalemsteles matuzalemsteles added the comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) label May 16, 2023
@matuzalemsteles matuzalemsteles self-assigned this May 26, 2023
@matuzalemsteles matuzalemsteles mentioned this issue May 26, 2023
Merged
@github-actions
Copy link

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-185488

@sandrodw3 sandrodw3 mentioned this issue Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matuzalemsteles matuzalemsteles

Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) rfc Similar to the RFC that are used in React.js, Ember.js, Gatsby.js and Rust, but to mark problems tha
Projects
None yet
Milestone
LPS-185488 Weekly Clay release May 29...
Development

Successfully merging a pull request may close this issue.

feat(@clayui/card): moves root aria-label to card titles matuzalemsteles/clay
2 participants
@sandrodw3 @matuzalemsteles