Skip to content
This repository has been archived by the owner on Dec 5, 2020. It is now read-only.

"upgrade" Gulp task: missing file headers in css.diff #205

Closed
wincent opened this issue Mar 14, 2019 · 2 comments
Closed

"upgrade" Gulp task: missing file headers in css.diff #205

wincent opened this issue Mar 14, 2019 · 2 comments

Comments

@wincent
Copy link
Contributor

wincent commented Mar 14, 2019

I am not sure if this is still an issue, but it was originally reported here:

liferay/liferay-theme-tasks#44

and mentioned in:

#48

I just added a PR that closes #48:

#203

so I am creating this issue to reflect the open question about whether the originally reported issue is resolved.

I won't paste the original text in as it is rather long, and I'm not actually sure how to summarize it. @blzaugg might be able to provide some more clarity on exactly what would be required?

@blzaugg
Copy link
Contributor

blzaugg commented Mar 14, 2019

Whoever wrote that original ticket should sit in a corner, and think about what they've done.

I believe what I was after is...

All other "file headers" look like:

Index: file-name.ext
===================================================================
--- file-name.ext	Original File
+++ file-name.ext	Updated File

But for some reason custom.css/custom.scss is just:

===================================================================
--- file-name.ext	Original File
+++ file-name.ext	Updated File

Maybe because of the rename?

I'm not sure if this is [still] an issue.

@wincent
Copy link
Contributor Author

wincent commented Dec 4, 2020

We've just migrated this project to the liferay-frontend-projects monorepo in the name of consolidation. As this issue is quite old now, I'm not going to transfer it automatically. If you consider it to be still relevant, please create a fresh issue over in the new repo.

@wincent wincent closed this as completed Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants