Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[liferay workspace]provide tooling to better support extending themes using relative paths in package.json #274

Closed
gamerson opened this issue Oct 7, 2020 · 3 comments

Comments

@gamerson
Copy link
Member

gamerson commented Oct 7, 2020

Lets say that you have two themes in a Liferay Workspace and wondering how to do it specifically in a CI build.

@jbalsas suggested the use of manually adding relative paths in the package.json. You can see I've added an example of that here:

https://github.com/gamerson/two-themes-test/blob/main/themes/extended-theme/package.json#L19
https://github.com/gamerson/two-themes-test/blob/main/themes/extended-theme/package.json#L45

Ideally, it would be good to add some more "tooling" up front to help developers in a Liferay workspace configure these relative paths.

@gamerson
Copy link
Member Author

gamerson commented Oct 7, 2020

cc @david-truong

@wincent wincent transferred this issue from liferay/liferay-js-themes-toolkit Dec 4, 2020
@izaera
Copy link
Member

izaera commented May 12, 2021

@gamerson Is this still needed? I guess it is...

@izaera
Copy link
Member

izaera commented May 17, 2022

Closing this due to inactivity

@izaera izaera closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants