Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github action workflow files #25

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

jooolia
Copy link
Member

@jooolia jooolia commented May 20, 2024

Update to Github workflow files pkgdown, R-CMD-check and test-coverage and pkgcheck so that workflows run and pass in Github actions for this package.

R-CMD-check:
Notably there seems to be the known issue when using the Ubuntu action runners that the dependencies for libcurl are problematic. Following the advice here:https://forum.posit.co/t/libraptor2-dev-depends-libcurl4-gnutls-dev-but-it-is-not-installable-in-r-lib-actions-setup-r-dependencies-v2/181572/4 I have edited the R-CMD-check to manually install the dependencies while awaiting this "apt-satisfy" fix (r-lib/pak#591)

pkgdown: changed runner to macos-latest (from ubuntu-latest)

test-coverage: changed runner to macos-latest (from ubuntu-latest)

pkgcheck: removed as could not find a workaround in the time I had to work on this.

Fixes #24 which is blocking ropensci/software-review#590

Please let me know what you think. I will also check with some of the editors to see if there are some other ways to enable the checks to pass.

@salvafern salvafern merged commit f054f57 into ropensci:dev Jun 3, 2024
@salvafern
Copy link
Collaborator

Sounds like a good solution until pak is fixed. Thank you so much @jooolia !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants