refacto: Optimize loading #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add env var in widget component
oktapodia
added
the
feature
|
Hey! Those are your new endpoints: https://feat-lf8368.jumper.exchange |
tcheee
reviewed
Jun 11, 2024
| const { activeTab, setActiveTab } = useActiveTabStore(); | ||
| const { welcomeScreenClosed, setWelcomeScreenClosed } = | ||
| useWelcomeScreen(closedWelcomeScreen); | ||
| const { setWelcomeScreenClosed } = useWelcomeScreen(closedWelcomeScreen); |
There was a problem hiding this comment.
should not we rename this file?
There was a problem hiding this comment.
No clue how to rename it :( any idea?
| const pathname = usePathname(); | ||
| const { trackEvent } = useUserTracking(); | ||
| const [starterVariantUsed, setStarterVariantUsed] = useState(false); | ||
| const [_starterVariant, setStarterVariant] = useState< |
There was a problem hiding this comment.
might be another ticket to adapt this logic elsewhere for the tabs
There was a problem hiding this comment.
A little bit for now, removing a part of it on each of my pr :s
|
One more problem here: Widget does not seem to show full width when expanded. |
|
Also, unfortunately we do not maintain the state of a tab now: maintain-widget-states-screen-capture.webm |
dennyscode
requested changes
Jun 13, 2024
dennyscode
approved these changes
Jun 20, 2024
tcheee
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
