-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: persist menu in DOM #969
Merged
tcheee
merged 9 commits into
develop
from
LF-7878-jumper-next-js-re-iteration-make-menus-appear-in-dom
May 23, 2024
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0df379e
chore: make menu persistent in dom
dennyscode e7fe1c3
Merge branch 'develop' into LF-7878-jumper-next-js-re-iteration-make-…
dennyscode 5eeef0b
Merge branch 'develop' into LF-7878-jumper-next-js-re-iteration-make-…
dennyscode e5789f9
chore: fix menus
dennyscode e26e7fa
Merge branch 'develop' into LF-7878-jumper-next-js-re-iteration-make-…
dennyscode 691ccdf
fix: typescript errors
dennyscode a9b49a1
Merge branch 'develop' into LF-7878-jumper-next-js-re-iteration-make-…
dennyscode d57a28b
refactor: use mui clickawaylistener
dennyscode cf6bc3c
Merge branch 'develop' into LF-7878-jumper-next-js-re-iteration-make-…
dennyscode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import { useMenuStore } from '@/stores/menu/MenuStore'; | ||
import type { PropsWithChildren } from 'react'; | ||
import { MenuClickAwayBox } from './Menu.style'; | ||
interface MenuClickAwayListenerProps { | ||
open: boolean; | ||
} | ||
|
||
export const MenuClickAwayListener: React.FC< | ||
PropsWithChildren<MenuClickAwayListenerProps> | ||
> = ({ open, children }) => { | ||
const { closeAllMenus } = useMenuStore((state) => state); | ||
|
||
return ( | ||
<MenuClickAwayBox | ||
open={open} | ||
className="click-away" | ||
onClick={(event) => { | ||
event.preventDefault(); | ||
console.log('Click Away Listener', event.target); | ||
event.stopPropagation(); | ||
// closeAllMenus(); | ||
}} | ||
> | ||
{children} | ||
</MenuClickAwayBox> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
'use client'; | ||
import type { | ||
ListItemProps, | ||
MenuItemProps as MUIMenuItemProps, | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunate, but I wasted too much time with the MUI clickawaylistener and decided to drop it in favor of a component which handles just that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer to remove the div to be able to keep the click on the widget and not the double click