feat: add gate wallet #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhikumar98
previously approved these changes
Sep 1, 2023
chybisov
approved these changes
Sep 6, 2023
0xsebn
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
https://lifi.atlassian.net/browse/LF-4592?atlOrigin=eyJpIjoiY2ZhNzIwOTA0NTg0NGRkOWJmODgxOWE2ZmY1Mzc3NDMiLCJwIjoiaiJ9
Reason this is on wait
This wallet seems to be extremely buggy. the connection call only works 1 out of 10 times. Most often the wallet does just not return anything and does not fulfill the connection promise. Even their UI is not updating correctly on a connection request. Please refer to the ticket comments for more info. I created this ticket anyways if we can get them to solve their bugs but would discourage merging this in it's current state