fix: hide browser wallets for mobile and tablets #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in mobile and desktop (responsive), wallet seems to be connecting fine. Although, more testing is required pre-deployment |
chybisov
requested changes
Sep 15, 2023
packages/widget/src/pages/SelectWalletPage/SelectWalletPage.tsx
Outdated
Show resolved
Hide resolved
|
Hey! This is your new endopint: https://6697cbb8.widget-lf3298hide.pages.dev |
|
Hey! This is your new endopint: https://76a11414.widget-lf3298hide.pages.dev |
chybisov
approved these changes
Sep 18, 2023
|
@chybisov it seems when embedded in a mobile app I don't see this change being triggered, any idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the website is opened in desktop view:
When the website is opened in mobile/responsive view:
The requirement is to hide the browser wallets and show users the correct option for connecting their wallets via walletconnect.