Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changing height and present widget better for mobile #276

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DNR500
Copy link
Contributor

@DNR500 DNR500 commented Jul 19, 2024

Work in progress

This branch looks to facilitate some of the changes for following tickets which are kind of inter-related

Jira: LF-3514
Jira: LF-8614
Jira: LF-8615

Started by making the height of the widget configurable using the containers height in the config so...

container: {
   height: 1000,
},

Also been looking to facilitate some form of full height solution for the mobile experience

I started by using '100vh' on the container height just to get to the point where I can see the what would be impacted from a 'full height' mobile experience.

I added in a flag to change a few things on some pages - mainly moving some of the interactive elements to the bottom of the pages for the mobile layout - this is common in a lot of mobile apps.

I think rather than using '100vh' for the container height that we might have a better experience looking to use a flex based approach to full height - this might also allow for integrators to incorporate the widget alongside other elements on a page more easily - will look at this next. I also think that this might have benefits for the scrolling experience for users and also help to better establish minimum height in parts of the widget.

For the virtualised token lists - these actually seemed to work well when a developer might only set the height once in the config - so for it works for page initialialisation and the initial page mount. Dynamically updating the height after mounting however will not currently update the virtualised token list height.

As mobile users can flip their phones between landscape and portrait I think we might have to look at re-establishing the height on the token list when that happens.

Whether we want to think about updating the token list height on a container height update from the config is also worth asking

@DNR500 DNR500 added the WIP Work in progress label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant