Allow passing flags down from commands to CLI tools

bin/cli.js

@@ -13,8 +13,12 @@ const { description, homepage } = require('../package.json');
   const learnMore = `Read the manual at ${homepage}`;
   const { npm_lifecycle_event: lifecycleEvent } = process.env;
 
-  if (argv.length === 0 && lifecycleEvent) {
-    argv.push(lifecycleEvent);
+  if (lifecycleEvent) {
+    argv.splice(0, 0, lifecycleEvent);
+  }
+
+  if (argv.length > 1) {
+    argv.splice(1, 0, '--');
   }
 
   yargs(argv)

lib/commands/build-docs.js

@@ -7,11 +7,16 @@ const { readFile, writeFile } = require('fs').promises;
 
 const { fileExists, loadConfig } = require('../utils');
 
+const command = path.parse(__filename).name;
+
 module.exports = {
-  command: path.parse(__filename).name,
+  command,
   describe: 'Builds the README.md file from the JSDoc in the codebase.',
   handler: async () => {
-    $.verbose = false;
+    if (process.argv[2] === command) {
+      process.argv.splice(2, 1);
+    }
+    $.verbose = true;
     const cwd = process.cwd();
     const readmePath = path.resolve(cwd, 'README.md');
     const { docs } = await loadConfig();
@@ -28,7 +33,7 @@ module.exports = {
     const output = await jsdocToMd.render(cfg);
     await writeFile(readmePath, output, 'utf8');
     await $`git add ./README.md`;
-    const cli = path.relative(process.cwd(), path.resolve(__dirname, '../../bin/cli.js'));
-    await $`${cli} prettier`;
+    // const cli = path.relative(process.cwd(), path.resolve(__dirname, '../../bin/cli.js'));
+    // await $`${cli} prettier`;
   }
 };

lib/commands/build-types.js

@@ -9,12 +9,12 @@ module.exports = {
   command,
   describe: 'Build the types with TypeScript.',
   handler: async () => {
+    if (process.argv[2] === command) {
+      process.argv.splice(2, 1);
+    }
     $.verbose = false;
     const cli = path.relative(process.cwd(), path.resolve(__dirname, '../../bin/cli.js'));
     await $`${cli} clean-types`;
-    if (process.argv.slice(-1)[0] === command) {
-      process.argv.splice(2, 1);
-    }
     process.argv.push('--emitDeclarationOnly');
     require('typescript/bin/tsc');
   }

lib/commands/check-types.js

@@ -8,7 +8,7 @@ module.exports = {
   command,
   describe: 'Check the types with TypeScript.',
   handler: async () => {
-    if (process.argv.slice(-1)[0] === command) {
+    if (process.argv[2] === command) {
       process.argv.splice(2, 1);
     }
     process.argv.push('--noEmit');

lib/commands/clean-types.js

@@ -3,10 +3,8 @@
 const path = require('path');
 const { $ } = require('zx');
 
-const command = path.parse(__filename).name;
-
 module.exports = {
-  command,
+  command: path.parse(__filename).name,
   describe: 'Delete all the types generated with TypeScript.',
   handler: async () => {
     $.verbose = false;

lib/commands/eslint.js

@@ -2,10 +2,15 @@
 
 const path = require('path');
 
+const command = path.parse(__filename).name;
+
 module.exports = {
-  command: path.parse(__filename).name,
+  command,
   describe: 'Check the codebase with ESLint.',
   handler: async () => {
+    if (process.argv[2] === command) {
+      process.argv.splice(2, 1);
+    }
     process.argv.push(...[['.'], ['--ext', '.js,.json,.md'], ['--ignore-pattern', '!.*.*']].flat());
     require('eslint/bin/eslint');
   }

lib/commands/prettier.js

@@ -8,10 +8,10 @@ module.exports = {
   command,
   describe: 'Format the codebase with Prettier.',
   handler: async () => {
-    const exts = ['hbs', 'js', 'json', 'md', 'ts'];
-    if (process.argv.slice(-1)[0] === command) {
+    if (process.argv[2] === command) {
       process.argv.splice(2, 1);
     }
+    const exts = ['hbs', 'js', 'json', 'md', 'ts'];
     process.argv.push('--write', `**/*.{${exts.join(',')}}`, '.*rc', '!coverage/**/*');
     require('prettier/bin-prettier');
   }

lib/commands/sync.js

@@ -96,10 +96,15 @@ module.exports = {
       version: cmd
     };
 
+    // Remove the legacy core-commons tag.
+    pkg['@lifion/core-commons'] = undefined;
+
     // Store the changes in the target package.json file.
     await storeJsonFile('./package.json', pkg);
 
-    // Upgrade dependencies.
+    // Upgrade and reconcile dependencies.
     await $`npx lifion-verify-deps -u`;
+    await $`rm -rf ./node_modules ./package-lock.json`;
+    await $`npm install`;
   }
 };

lib/commands/test.js

@@ -6,10 +6,15 @@ const { $ } = require('zx');
 
 const { loadConfig } = require('../utils');
 
+const command = path.parse(__filename).name;
+
 module.exports = {
-  command: path.parse(__filename).name,
+  command,
   describe: 'Run tests with Jest.',
   handler: async () => {
+    if (process.argv[2] === command) {
+      process.argv.splice(2, 1);
+    }
     $.verbose = false;
     await $`mkdir -p ./reports`;
     const { test } = await loadConfig();