Skip to content

Commit

Permalink
Fix skipped unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jennyEckstein committed Nov 10, 2021
1 parent 1cfa731 commit fc59855
Show file tree
Hide file tree
Showing 2 changed files with 222 additions and 148 deletions.
9 changes: 6 additions & 3 deletions lib/index.js
Expand Up @@ -44,7 +44,7 @@ async function getLatestVersions(name) {
} catch (err) {
const message =
err instanceof SyntaxError
? `Failed to parse output from NPM view - ${err.toString()}`
? `Failed to parse output from NPM view when getting versions - ${err.toString()}`
: `Error getting latest versions - ${err}`;
throw new Error(message);
}
Expand All @@ -66,7 +66,7 @@ async function getLatestTag(name) {
} catch (err) {
const message =
err instanceof SyntaxError
? `Failed to parse output from NPM view - ${err.toString()}`
? `Failed to parse output from NPM view when getting tags - ${err.toString()}`
: `Error getting latest tag - ${err}`;
throw new Error(message);
}
Expand All @@ -83,8 +83,9 @@ async function getLatestTag(name) {
async function getLatestVersion(name, wanted) {
const versions = await getLatestVersions(name);
const latest = await getLatestTag(name);
console.warn('getLatestVersion versions:', versions);
let applicableVersions = versions.filter((i) => semver.satisfies(i, wanted));

console.warn('applicableVersions', applicableVersions);
const prereleases = [];
if (semverPrerelease(wanted.slice(1))) {
for (const version of versions) {
Expand Down Expand Up @@ -143,6 +144,7 @@ function pushPkgs({ deps, dir, logger, type }) {
return Object.keys(deps).map(async (name) => {
const wanted = deps[name];
const installed = getInstalledVersion(dir, name, logger);
console.warn('installed:', installed);
const latest = await getLatestVersion(name, wanted);
const wantedFixed = wanted.slice(1);
const shouldBeInstalled =
Expand Down Expand Up @@ -206,6 +208,7 @@ async function verifyDeps({ autoUpgrade = false, dir = '', logger = console } =
...pushPkgs({ deps: removeLockedDependencies(dependencies), dir, logger, type: 'prod' }),
...pushPkgs({ deps: removeLockedDependencies(devDependencies), dir, logger, type: 'dev' })
]);
console.warn(pkgs);
const toInstall = pkgs.filter(({ shouldBeInstalled }) => shouldBeInstalled);
if (toInstall.length > 0) {
const prodPkgs = toInstall.filter(({ type }) => type === 'prod');
Expand Down

0 comments on commit fc59855

Please sign in to comment.