StackOverFlow error caused by recursion in newConnection

[dj22]

In DB.scala newConnection can fail and recursively call itself until the stack overflows. We have seen this happen using both Oracle and H2-Server when the database becomes unavailable and therefore connections to it fail.

[serioga]

The link to discussion is https://groups.google.com/d/topic/liftweb/hHW_R9Rd4uY/discussion

[constantine2nd]

Solution: Fix bug and prevent StackOverFlow via loop function

Fix: do not increase the pool size in case of invalid connection
Improvement: rewrite recursive to loop function