Remove custom equals methods in mongo-record test fixtures #1396

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

eltimn commented Jan 10, 2013

Some tests were failing when compiling with scala 2.10.0.

@ghost ghost assigned eltimn Jan 10, 2013

Is this something to include in the "Breaking changes" section when we publish 2.5-M4 ?

Member

eltimn replied Jan 13, 2013

No. Nothing changed in the behavior, I just made a note here and added this function, in case anyone wants to use it.

All this commit did was change the tests so they actually used the equals method, instead of the custom one I had written, which was comparing Strings. I just wanted to note anywhere that the equals methods wasn't working as expected, since the setting of the dirty flag now relies on it.

Owner

fmpwizard replied Jan 13, 2013

awesome, thanks!

Owner

fmpwizard commented Jan 11, 2013

+1

Owner

fmpwizard commented Jan 12, 2013

rebased to master and will be part of M4, thanks!

@fmpwizard fmpwizard closed this Jan 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment