Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally relevant: Support for custom attributes on each option of a select. #1426

Closed
wants to merge 17 commits into from
Closed
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e26422b
Implement SelectableOption, and use it in place of tuples for select*.
farmdawgnation Mar 26, 2013
b607d97
Add an implicit conversion from tuple to SelectableOption.
farmdawgnation Mar 26, 2013
5e10b65
Refactor, improve readability for SHtml.checkbox[T].
farmdawgnation Mar 26, 2013
c2ab65f
Readability improvements to SHtml.secureOptions[T].
farmdawgnation Mar 26, 2013
648240b
Implement and use SelectableOptionWithNonce during processing.
farmdawgnation Mar 26, 2013
2d5b360
Readability improvements to SHtml.secureMultiOptions[T].
farmdawgnation Mar 26, 2013
eaa0455
Use SelectableOptionWithNonce in secureMultiOptions[T].
farmdawgnation Mar 26, 2013
14c000b
Set custom attributes for option tags in select_*.
farmdawgnation Mar 26, 2013
45279ab
Fix a MatchError related to the new SelectableOption.
farmdawgnation Mar 26, 2013
d410256
Populate custom option attributes in untrustedSelect_*.
farmdawgnation Mar 26, 2013
43debc3
Populate custom option attributes in untrustedMultiSelect_*.
farmdawgnation Mar 26, 2013
f237c7b
Populate custom option attributes in ajaxUntrustedSelect_*.
farmdawgnation Mar 26, 2013
1d05563
Implement SelectableOption support for ajaxSelect*
farmdawgnation Mar 26, 2013
114158b
Make the type bound on SelectableOption* more tolerant.
farmdawgnation Apr 1, 2013
8916b30
Clean up some rouge cases.
farmdawgnation Apr 13, 2013
226f634
Oops. Missed a case.
farmdawgnation Apr 13, 2013
bd94d33
Missed yet another case? Find/replace fails me again.
farmdawgnation Apr 14, 2013
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view