Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1513 Allow to return boolean values using the roundtrip function #1514

Merged
merged 1 commit into from Jan 22, 2014

Conversation

antidata
Copy link
Contributor

@fmpwizard
Copy link
Member

👍

I was going to ask about null vs undefined but then I saw this pull requests uses =! which will do what you expect for both, null and undefined (see http://stackoverflow.com/a/5101991/309896 for details)

@Shadowfiend
Copy link
Member

👍

@Shadowfiend
Copy link
Member

I'm going to hold off a day or two on this, as I want to get the master<->lift_30 merge done first, if that's okay with everyone.

@fmpwizard
Copy link
Member

sounds good (to wait for the other merge to go first)

@antidata
Copy link
Contributor Author

Amazing, thanks!

@Shadowfiend
Copy link
Member

Looks like things are kosher with the other merge, so let's play the game.

Shadowfiend added a commit that referenced this pull request Jan 22, 2014
#1513 Allow to return boolean values using the roundtrip function

Before, Lift client-side JS did a simple if (value) instead of an explicit
if (value != null)
@Shadowfiend Shadowfiend merged commit d9e1a73 into lift:lift_30 Jan 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants