Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listener Renaming: Rename updateListeners(Any) in ListenerManager #1574

Merged
merged 1 commit into from Jun 12, 2014
Merged

Listener Renaming: Rename updateListeners(Any) in ListenerManager #1574

merged 1 commit into from Jun 12, 2014

Commits on Jun 10, 2014

  1. updateListeners(Any)->sendListenersMessage. 

    We do this because there is an updateListeners overload that takes a
list of actors to update, which is optional. Having an updateListeners
overload that takes an Any makes it really easy to accidentally call the
wrong updateListeners method by having the wrong type of List.
Additionally, it's particularly confusing to have the two methods named
the same thing when they behave differently.

We name the method that sends all listeners a message that is passed in
`sendListenersMessage` and leave `updateListeners` for sending all
listeners the message generated by `createUpdate`.
    @Shadowfiend
    Shadowfiend committed Jun 10, 2014
    Copy the full SHA
    34de88d View commit details
    Browse the repository at this point in the history