TimeSpan represents duration in milliseconds. #1668
Conversation
Before the change TimeSpan has many responsibilities - in equality behave as a joda Period (was checking duration field equality), can represent a Date (using toDate/toDateTime operations) or be used as a simple container for milliseconds. Now is responsible only for operations on milliseconds. Problematic methods have been deprecated (.ago/.later have been moved to implicit PeriodExtension). For backward compatibility there is introduced implicit conversion from Period to TimeSpan.
| def toMillis = millis | ||
|
|
||
| /** | ||
| * @return amount of milliseconds in duration | ||
| * @throws UnsupportedOperationException if was created by deprecated months/years builder |
There was a problem hiding this comment.
This is documenting existing behavior rather than a new exception, right?
There was a problem hiding this comment.
Yest, It's documenting existing behavior
| def week = weeks | ||
| def months = new TimeSpan(Right((new Period().plusMonths(len.toInt)))) | ||
| @deprecated("TimeSpan will not support operations on non-millis periods in future") |
There was a problem hiding this comment.
I believe @deprecated takes two parameters, one is the text you have here and the other is the version, so 3.0
There was a problem hiding this comment.
Let's use 3.0.0. I think it's worth going full semver for the 3 series, because why not :)
- deprecation since version notice added
|
Let me know when you fill that all looks fine. Then I will prepare branch with squashed changes. |
|
Sorry, I haven't had a chance to give this a second, deeper look. I'll try and do that tomorrow so we can roll out the M3 build! For time's sake, if everything looks reasonably good I'll probably make any tweaks to history and verbiage and merge it in at that time. |
|
Okay, I want most of this to land in M3, so I undid one thing I want to discuss a little more–namely the deprecations on I also reworded some of the deprecation notices and listed alternatives for all of them, and added a block about the deprecation to the I put the result in #1670; let's try to merge that, close this, and resolve the remaining couple of questions on the list! |
Mailing list discussion: https://groups.google.com/forum/#!topic/liftweb/CgZFVwMEiqU
Before the change TimeSpan has many responsibilities - in equality behave as a joda Period (was checking duration field equality), can represent a Date (using toDate/toDateTime operations) or be used as a simple container for milliseconds. Now is responsible only for operations on milliseconds. Problematic methods have been deprecated (.ago/.later have been moved to implicit PeriodExtension). For backward compatibility there is introduced implicit conversion from Period to TimeSpan.
Period inside TimeSpan is holded now only for puropose of to-period conversion (for months/years builder). There has been used view bounds for purpose of nested conversions usage:
1.second.before
1 -> TimeSpan -> Period
This is WIP branch. Please send me feedback if my english has failed in deprecation descriptions :-)