Upgrade mongo-java-driver to v2.14.0 #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ObjectId.isValid(id) match { | ||
| case true => Full(set(new DBRef(dbo.get("$ref").toString, new ObjectId(id)))) | ||
| case false => Full(set(new DBRef(dbo.get("$ref").toString, id))) | ||
| } |
There was a problem hiding this comment.
So can this no longer fail? I see we're going to a Full box always, but we weren't before I guess?
There was a problem hiding this comment.
We used to have to fetch the DB, but DBRef no longer supports that. So, yeah, it will always beFull now. Not really sure how else to handle this.
There was a problem hiding this comment.
Yeah, I think this is fine, just wanted to double-check.
|
Looks good to me! |
Shadowfiend
added a commit
that referenced
this pull request
Dec 29, 2015
Upgrade mongo-java-driver to v2.14.0 We can't upgrade to the 3 series until we remove a few functions, which I've deprecated in this commit. This version is compatible with the latest server versions, so it should be sufficient for a while longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1747
We can't upgrade to the 3 series until we remove a few functions, which I've deprecated in this commit. This version is compatible with the latest server versions, so it should be sufficient for a while longer.