New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape jQuery identifiers #1796
Conversation
If you have an identifier with a . character in it, for example, <input id="name.first" /> jQuery will try to find an element with id "name" and class "first". This is unexpected behavior. In this case, the "." must be escaped with a backslash.
If we're going to fix this, should we fix it for all of the meta characters where this is a problem? This SO entry has some good info on the problem. I think using this is probably the best way to go:
|
Good call. I'll update my local env and test a little bit. If it looks good there, I'll update the pr. |
Instead of trying to escape id selectors, use document.getElementById
quick question, why is this marked for 3.1 and not for the next RC? |
IIRC, it's not a regression, so there was no reason to hold up a 3.0 final release for it (this was opened after th RC cycle began). |
ok, and I imagine we don't want to add it now to the next RC in case of a regression caused by this fix, right? (because there will be another RC to handle that one js bug we still have) |
Right. Basically I think the RCs should be frozen to forward development; we should only fix regressions. |
Soo I think we can move forward on this. @eltimn it sounds like you had a look here? We good to go? |
Yes. Looks good. |
All in then! |
As discussed on the forum.
See: https://groups.google.com/forum/#!topic/liftweb/jorUqMmCLDQ