Skip to content

Commit

Permalink
Add config parse tests
Browse files Browse the repository at this point in the history
  • Loading branch information
tylertreat committed Oct 30, 2019
1 parent 074dd59 commit 473b7ec
Show file tree
Hide file tree
Showing 6 changed files with 45 additions and 1 deletion.
32 changes: 31 additions & 1 deletion server/config_test.go
Expand Up @@ -42,12 +42,42 @@ func TestNewConfig(t *testing.T) {
require.Equal(t, 2*time.Second, config.Clustering.ReplicaMaxIdleWait)
require.Equal(t, 3*time.Second, config.Clustering.ReplicaFetchTimeout)
require.Equal(t, 1, config.Clustering.MinISR)

require.Equal(t, []string{"nats://localhost:4222"}, config.NATS.Servers)
}

// Ensure we can properly parse NATS username and password from a config file.
func TestConfigParseNATSAuth(t *testing.T) {
func TestNewConfigNATSAuth(t *testing.T) {
config, err := NewConfig("configs/nats_auth.conf")
require.NoError(t, err)
require.Equal(t, "admin", config.NATS.User)
require.Equal(t, "password", config.NATS.Password)
}

// Ensure an error is returned when there is an unknown setting in a config
// file.
func TestNewConfigInvalidSetting(t *testing.T) {
_, err := NewConfig("configs/invalid.conf")
require.Error(t, err)
}

// Ensure an error is returned when there is an unknown log setting in a config
// file.
func TestNewConfigInvalidLogSetting(t *testing.T) {
_, err := NewConfig("configs/invalid_log.conf")
require.Error(t, err)
}

// Ensure an error is returned when there is an unknown NATS setting in a
// config file.
func TestNewConfigInvalidNATSSetting(t *testing.T) {
_, err := NewConfig("configs/invalid_nats.conf")
require.Error(t, err)
}

// Ensure an error is returned when there is an unknown clustering setting in a
// config file.
func TestNewConfigInvalidClusteringSetting(t *testing.T) {
_, err := NewConfig("configs/invalid_clustering.conf")
require.Error(t, err)
}
4 changes: 4 additions & 0 deletions server/configs/full.conf
Expand Up @@ -32,3 +32,7 @@ clustering {
replica.fetch.timeout: "3s"
min.insync.replicas: 1
}

nats {
servers: [nats://localhost:4222]
}
1 change: 1 addition & 0 deletions server/configs/invalid.conf
@@ -0,0 +1 @@
foo: bar
3 changes: 3 additions & 0 deletions server/configs/invalid_clustering.conf
@@ -0,0 +1,3 @@
clustering {
foo: bar
}
3 changes: 3 additions & 0 deletions server/configs/invalid_log.conf
@@ -0,0 +1,3 @@
log {
foo: bar
}
3 changes: 3 additions & 0 deletions server/configs/invalid_nats.conf
@@ -0,0 +1,3 @@
nats {
foo: bar
}

0 comments on commit 473b7ec

Please sign in to comment.