Fix leader partition edge case #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send the leader epoch on replication requests. When a partition leader receives a replication request, check that the leader epoch is the current leader's epoch. If not, drop the request. This fixes an edge case where a leader is partitioned from the rest of the ISR and a new partition leader is elected. Previously, both the old leader and new leader would receive the replication requests. Followers would reject responses from the old leader, but the old leader would still commit messages due to the replication requests sent by followers and stay in a zombie state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the leader epoch on replication requests. When a partition leader
receives a replication request, check that the leader epoch is the
current leader's epoch. If not, drop the request.
This fixes an edge case where a leader is partitioned from the rest of
the ISR and a new partition leader is elected. Previously, both the old
leader and new leader would receive the replication requests. Followers
would reject responses from the old leader, but the old leader would
still commit messages due to the replication requests sent by followers
and stay in a zombie state.