use libm::exp2 #21
Merged
use libm::exp2 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
hexfas a transitive dependencywgpu-hal -> naga -> hexf-parsein Deno. Unfortuanetly this pulls in a GLIBC dependency onexpf2because LLVM optimizes2.0.powf(exp)toexp2f.exp2fis not present in glibc 2.23 and hence Deno is not able to run on Ubuntu 16, Amazon Linux, etc.Ref denoland/deno#13516 (comment)
This patch introduces
libm::exp2to avoid the above issue.