Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept strings of the form "0x0p0", with no dot. #4

Merged
merged 2 commits into from
Mar 28, 2021

Conversation

sunfishcode
Copy link
Contributor

GLIBC's and musl's printf with %a formats zero as "0x0p+0", with no dot, so
accept strings of that form.

@youknowone
Copy link
Collaborator

Hi, I am really sorry not to reply anything to this PR for so long time.
I am a new maintainer and I want to add this feature in future hexf. But recently we changed codebase to fit recent rust environment, so it needs rebase to go to be merged. If you are still interested in this PR, would you please rebase it to recent code base? I promise I will do proper further work in that case.
If you are not instersted in this PR anymore, just please let me know. That's totally understandable after many months since creating the PR.

GLIBC's and musl's printf with %a formats zero as "0x0p+0", with no dot, so
accept strings of that form.
@sunfishcode
Copy link
Contributor Author

Thanks! I've now rebased this, and added a few more tests too.

Copy link
Collaborator

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@youknowone youknowone merged commit 9a0f017 into lifthrasiir:master Mar 28, 2021
@sunfishcode sunfishcode deleted the master branch December 22, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants