This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
s/Makefile/CMakelists.txt #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pgoodman
approved these changes
Jul 10, 2018
pgoodman
reviewed
Jul 10, 2018
CMakeLists.txt
Outdated
| enable_language(ASM) | ||
|
|
||
| # What compilers are we using? | ||
| set(CMAKE_C_COMPILER "clang-3.8") |
There was a problem hiding this comment.
This I think is the one change I'd like to see. Can you see if you can detect if the cmake compiler is not a variant of clang, and error out? Hard-coding clang 3.8 should not be necessary anymore.
There was a problem hiding this comment.
Done in 395631b.
ianklatzco
force-pushed
the
add-cmakelists
branch
from
b1a6ae8
to
2423d89
Compare
pgoodman
suggested changes
Jul 11, 2018
CMakeLists.txt
Outdated
| set(CMAKE_C_COMPILER "clang-3.8") | ||
| set(CMAKE_CXX_COMPILER "clang++-3.8") | ||
| set(CMAKE_ASM_COMPILER "clang-3.8") | ||
| if (NOT ${CMAKE_C_COMPILER} MATCHES ".*clang") |
There was a problem hiding this comment.
I'd recommend instead trying this test: https://stackoverflow.com/questions/10046114/in-cmake-how-can-i-test-if-the-compiler-is-clang
There was a problem hiding this comment.
Done in 7fb8fe9.
pgoodman
approved these changes
Jul 18, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a straightforward port of the Makefile. I've tested lightly (running
grrshoton a binary out of cb-multios, compiled for linux/decree, debug/release) and things appear to be correct.