Fix overzealous substitution in NestedCondProp
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgoodman
approved these changes
Mar 24, 2022
frabert
added a commit
that referenced
this pull request
Mar 24, 2022
* Add regression test * Fix overzealous propagation
frabert
added a commit
that referenced
this pull request
Mar 29, 2022
* WIP: Provide provenance info for `llvm::Use`s * Fix dangling uses * Fix missing decl * Fix overzealous substitution in `NestedCondProp` (#247) * Add regression test * Fix overzealous propagation * Do not assume variables stay constant * Fix provenance tracking * Refactor `rellic-xref` * Bundle all provenance info in a single struct * Revert multimaps to standard maps * Remove confusing method * Explain `BlockVisitor` * Remove wrapper * Put `BlockVisitor` in a separate file * Rename `GetOperandExpr` to `CreateOperandExpr` * Refactor `IRToASTVisitor` * Separate method declarations and definitions Also fixes #249 and #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.