38 image opening closing animation is slow #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per issue, a custom animation has been added for goToMedia, with relevant toggle to enable or disable animations allowing the user to effectively turn off the transition (reduce to 1ms). Uses config_store.
Set to 200ms which seems to match the default for FadeTransition that was used previously.
|
LGTM. @mykdavies could you confirm this looks fine on iOS? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option in appearance settings to disable image preview animation, using a custom TweenAnimationBuilder. Uses config_store bool to switch between 1ms and 200ms.
Please code-review, I'm relatively new to flutter and this was me dipping my toe in the water on a relatively easy issue.