Add gesture navigation #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out there's a convenient library caled swipeable_page_route that adds exactly the behavior that other aps like Reddit Sync and Apollo did.
|
Looks like someone created issue #59 requesting this functionality. |
|
Hi @shocklateboy92 I was able to build your branch and tested on android. Swiping does work on full posts. I also couldn't fix the android errors when trying to build for my IDE, but I was able to create a release one using |
|
How about making it optional? It conflicts with the device's gestures and make it go back twice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there's a convenient library caled swipeable_page_route that adds exactly the behavior that other apps like Reddit Sync and Apollo had.
Disclaimer: I only tested it on the Linux build, as I can't build android packages on my machine due to some weird errors I don't have the energy to investigate right now.