fixed a bug in ssh_connect.py when /bin/sh is a symlink #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the script ssh_connect.py terminated when the /bin/sh is a symlink to busybox or dash (e.g. on RPi's)
addition to commit 2ab2402
liftoff
added a commit
that referenced
this pull request
Nov 12, 2015
Fixed a bug in ssh_connect.py when /bin/sh is a symlink. Thanks to mammo0 for the PR.
|
Thanks for this fix. It's actually kinda clever how it works 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an addition to PR #505.
It checks not only if
/bin/shis linked to 'busybox' but if it's a symlink in general. With this fix the PR #505 works on more platforms.