Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow to specify ordering of build phases #204

Closed
bitcrumb opened this issue Dec 5, 2014 · 4 comments
Closed

[Feature] Allow to specify ordering of build phases #204

bitcrumb opened this issue Dec 5, 2014 · 4 comments

Comments

@bitcrumb
Copy link
Contributor

bitcrumb commented Dec 5, 2014

While experimenting with my own template setup, I needed to be able to insert a build phase at a specific point. More specifically before the 'Copy Bundle Resources' phase (since it was a script that would modify some app icons & overlay it with some text).

Would this be an addition that others would find useful as well? Not too sure yet how I would go about this (especially configuration-wise), but it certainly should be doable.

@Zyhlon
Copy link

Zyhlon commented Dec 19, 2014

Yes, please! We're using xcres to generate a resource file, which would be nice to do before compile, especially in case of merge conflicts. So there you have another use case for it.

(We also have an icon annotation script, but run it on the images already moved to the bundle as to keep the repository clean. Not sure if that's what you want as well, but I'd be happy to point you to a snippet for it if you like)

@bitcrumb
Copy link
Contributor Author

I use this one at the moment: https://gist.github.com/dulaccc/a52154ac4c007db2be55
Sure would be helpful if you could point me to yours :)

Unfortunately, didn't have the time yet to start on the suggested feature btw.

@Zyhlon
Copy link

Zyhlon commented Dec 29, 2014

This is a (hopefully) more general (and a bit more involved) version of what I use: https://github.com/krzysztofzablocki/IconOverlaying/blob/master/Scripts/iconVersioning.sh .

No rush! It would just be nice to have :) As for how to specify the ordering in the configuration, perhaps one could split the configuration into parts: after_copy_bundle, after_compile, before_compile, etc?

champo pushed a commit to Monits/liftoff that referenced this issue Jan 22, 2015
Extended the script phase configuration to include a new form that
accepts a key index. The value is then used as index for inserting the
phase into the project.
@gfontenot
Copy link
Member

This is in master with 98814ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants