Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve detection of Test Targets #218

Closed
AliSoftware opened this issue Mar 24, 2015 · 0 comments 路 Fixed by #251
Closed

Improve detection of Test Targets #218

AliSoftware opened this issue Mar 24, 2015 · 0 comments 路 Fixed by #251
Labels
enhancement
Milestone
1.6.0

Comments

@AliSoftware
Copy link
Contributor

Since #169 has been merged, we can customize the name of the Test Target and choose whatever we like 馃憤

But that is not consistant with how XcodeprojHelper#test_targets determines the list of test targets 馃槩

We should either:

  • Use the test_target_name specified during the config to inject it in this list
  • Use a better way to detect which targets are Test Targets, for example check which targets have xctest for their WRAPPER_EXTENSION build setting.
  • Use Xcodeproj to list PBXNativeTarget objects whose productType is com.apple.product-type.bundle.unit-test
@gfontenot gfontenot added this to the 1.6.0 milestone Sep 26, 2015
@gfontenot gfontenot mentioned this issue Nov 20, 2015
Merged
gfontenot added a commit that referenced this issue Nov 20, 2015
@gfontenot
Use equality when checking target names
3dbe9e1 
This should have been done as a part of #218 but I just straight up
forgot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Improve test target detection in xcodeproj_helper liftoffcli/liftoff
2 participants
@gfontenot @AliSoftware