fix: Use jsonpb for unmarshalling proto messages from json

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
ligato · Oct 15, 2019 · d41e5f2 · d41e5f2
1 parent 824dc65
commit d41e5f2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/datasync/syncbase/kv_iterator.go b/datasync/syncbase/kv_iterator.go
@@ -15,8 +15,9 @@
 package syncbase
 
 import (
-	"encoding/json"
+	"bytes"
 
+	"github.com/golang/protobuf/jsonpb"
 	"github.com/golang/protobuf/proto"
 	"github.com/ligato/cn-infra/datasync"
 )
@@ -97,7 +98,7 @@ func (kv *KeyValBytes) GetKey() string {
 
 // GetValue returns the value of the pair.
 func (kv *KeyValBytes) GetValue(message proto.Message) error {
-	return json.Unmarshal(kv.value, message)
+	return jsonpb.Unmarshal(bytes.NewReader(kv.value), message)
 }
 
 // GetRevision returns revision associated with the latest change in the key-value pair.

diff --git a/datasync/syncbase/msg/change_event.go b/datasync/syncbase/msg/change_event.go
@@ -15,9 +15,10 @@
 package msg
 
 import (
+	"bytes"
 	"context"
-	"encoding/json"
 
+	"github.com/golang/protobuf/jsonpb"
 	"github.com/golang/protobuf/proto"
 	"github.com/ligato/cn-infra/datasync"
 	"github.com/ligato/cn-infra/logging/logrus"
@@ -87,7 +88,7 @@ func (ev *ChangeWatchResp) GetRevision() int64 {
 
 // GetValue - see the comments in the interface datasync.ChangeEvent.
 func (ev *ChangeWatchResp) GetValue(val proto.Message) error {
-	return json.Unmarshal(ev.message.Content, val) //TODO use contentType...
+	return jsonpb.Unmarshal(bytes.NewReader(ev.message.Content), val) //TODO use contentType...
 }
 
 // GetPrevValue returns the value before change.