Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc.go #62

Merged
merged 3 commits into from
Aug 16, 2017
Merged

Update doc.go #62

merged 3 commits into from
Aug 16, 2017

Conversation

martinfrk
Copy link
Contributor

minor edits (grammar & typos)

minor edits (grammar & typos)
@@ -12,17 +12,17 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// Package statuscheck provides the API for reporting status changes from plugins to the statuscheck plugin,
// that exposes it via ETCD and HTTP.
// The statuscheck package provides an API for reporting status changes from plugins to the statuscheck plugin,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be changed because of golint (static analysis tool). It requires the package level comment to start with word Package...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. We can keep it as it is (and in other similar instances as well).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 49.862% when pulling b6d54ae on martinfrk:patch-23 into 0744d6b on ligato:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.862% when pulling 247e85c on martinfrk:patch-23 into 95e8340 on ligato:master.

@lukasmacko lukasmacko merged commit 0ecb556 into ligato:master Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants