Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add promethues metrics to govppmux #1626

Merged
merged 7 commits into from
Feb 21, 2020

Conversation

ondrej-fabry
Copy link
Member

@ondrej-fabry ondrej-fabry commented Feb 21, 2020

This PR contains:

  • add prometheus metrics to govppmux and telemetry (more to come)
  • fix parsing VPP version (strip zero bytes)
  • added integration test case for parsing VPP version
  • fix race condition when for concurrent stats retrievval from govppmux plugin
  • update version package and some minor code cleanups

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
pkg/version/version.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #1626 into master will increase coverage by 1.29%.
The diff coverage is 47.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1626      +/-   ##
==========================================
+ Coverage   57.72%   59.02%   +1.29%     
==========================================
  Files         486      284     -202     
  Lines       39721    23018   -16703     
==========================================
- Hits        22930    13586    -9344     
+ Misses      14384     8335    -6049     
+ Partials     2407     1097    -1310
Flag Coverage Δ
#e2e ?
#unittests 59.02% <47.42%> (+0.03%) ⬆️

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry self-assigned this Feb 21, 2020
@ondrej-fabry ondrej-fabry merged commit 2940321 into ligato:master Feb 21, 2020
@ondrej-fabry ondrej-fabry deleted the fixes branch February 21, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants