Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding checkPreAuth before authenticating #31

Closed
rudott opened this issue Nov 4, 2016 · 3 comments
Closed

Adding checkPreAuth before authenticating #31

rudott opened this issue Nov 4, 2016 · 3 comments

Comments

@rudott
Copy link
Contributor

rudott commented Nov 4, 2016

@tmilos In the old repository there was a PR for adding the checkPreAuth, is it possible to add this feature, because I think it would be necessary for extra security checks.
https://github.com/aerialship/SamlSPBundle/pull/44/files

By adding this check it's possible to add the default checks isAccountNonLocked, isEnabled & isAccountNonExpired by using the AdvancedUserInterface.

Should I create a PR for this (including the missing test)?

Thank you!
@tmilos
Copy link
Member

tmilos commented Nov 4, 2016

Yes please make the PR. I guess it should be placed right above existing checkPostAuth call since authentication actually is not really done internally by the system, but relays on the received assertions.

@rudott
Copy link
Contributor Author

rudott commented Nov 4, 2016

@tmilos thanks for your quick reply. I created the PR: #32

@tmilos
Copy link
Member

tmilos commented Nov 4, 2016

Merged and released in v1.0.3
Thanks

@tmilos tmilos closed this as completed Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rudott @tmilos