add support for SLO #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 2, 2016 16:33
- replacement of deprecated PHPUnit_Framework_TestCase::getMock with ::getMockBuilder
Logout support
Generalize logout response
tmilos
reviewed
Nov 22, 2016
| $sessions = $this->ssoStateStore->get()->getSsoSessions(); | ||
|
|
||
| if (count($sessions) === 0) { | ||
| return $this->createLogoutResponse(); |
There was a problem hiding this comment.
This method is called when there's no incoming message - thus IDP didn't sent a LogoutRequest. But, here, in case there are no sso sessions in store, we're making LogoutResponse that will get rejected by IDP. Isn't an exception better suited?
TM-2240: Dynamic entity id
|
Is there any progress on this? Thanks. |
* introduce default and idpdata metadata providers * introduce domain resolver api * bump required sf to min 2.4 * remove security bundle * remove prefer lowest suite from build * add bundle configuration for enabling idp data metadata provider * default and idp data metadata providers tests * bundle configuration tests * readme update * extension tests * use camelCase in tests methods * http api tests * restore default controller metadata action, remove default metadata provider and metadata provider factory * add idp data descriptor store service if idp data metadata provider enabled * introduce idp data entity descriptor store * fix definitions * fix tests * entity descriptor store, http api tests * remove unnecessary dependencies * test fix * restore http mock version * stores unit tests * phpcs * functional tests when idp-data enabled * fix tests * review improvements * test naming * exception naming
* injected IdpDataCredentialStore * return organisation field instead of whole array * refactored CompositeCredentialStore and added const to Apis * add missing X509CertificateIdpDataTest and HttpApiTest missing methods * store unit tests
…-change PPCDEV-6258 allow to enable idp-data with int
* PPCDEV-6430 - Sign Logout SAML Messages by default Many Identity Providers using SingleLogout requires that e.g LogoutRequest is signed - since that change don't affect logout requests without verification it's safe to make it a default behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening PR from a fork that was mentioned to have SLO support implemented.
@tmilos can you review and maybe merge it?