Upgrade PHPUnit to 8.4 min. #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorejb
reviewed
Apr 7, 2021
composer.json
Outdated
| "require": { | ||
| "php": ">=7.2.5", | ||
| "php": "^7.2.5|^8.0", |
There was a problem hiding this comment.
I don't think this change is good. It will prevent the library from being used with PHP 9+.
There was a problem hiding this comment.
I don't understand what you say because the latest php version is 8.0.2 .
There was a problem hiding this comment.
I wanna exclude php 9+ and it's probably safe to exclude 8.1+, isn't it ?
There was a problem hiding this comment.
No it's not. Why would you want to artificially exclude future PHP versions? This will make it harder for users to experiment with them and report any bugs. See this thread by a core maintainer of Symfony: https://mobile.twitter.com/nicolasgrekas/status/1263023258938548225
There was a problem hiding this comment.
Sounds good to me :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.