Add publish info #157
Add publish info #157
Conversation
| @@ -37,6 +37,11 @@ inThisBuild(Seq[Setting[_]]( | |||
| ) | |||
| )) | |||
|
|
|||
| ThisBuild / publishMavenStyle := true | |||
There was a problem hiding this comment.
This had to be done this way because of
Reference to undefined setting:
ThisBuild / sonatypePublishToBundle from ThisBuild / publishTo (/Users/mdedetrich/github/jardiff/build.sbt:3)
Did you mean core / sonatypePublishToBundle ?
At some point it may be better to just use ThisBuild / for everything but thats more a nicety
| @@ -37,6 +37,11 @@ inThisBuild(Seq[Setting[_]]( | |||
| ) | |||
| )) | |||
|
|
|||
| ThisBuild / publishMavenStyle := true | |||
| ThisBuild / publishTo := sonatypePublishToBundle.value | |||
| ThisBuild / test / publishArtifact := false | |||
There was a problem hiding this comment.
I should have asked before merging, but shouldn't this be Test, not test?
There was a problem hiding this comment.
and/or, is it even necessary? isn't false the default?
|
I just noticed that the sbt-ci-release readme says:
@mdedetrich This PR seems to contradict that advice? |
|
@SethTisue That may be the issue, however I just realized that the issue with publishing is apparently due to wrong credentials (see sbt/sbt-pgp#182) |
|
I've submitted #162 which reverts these changes. |
At the time you submitted this PR, I hadn't added the secrets yet. |
Likely causing the issues with not publishing correctly.