Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect changes to inner modules #143

Merged
merged 2 commits into from
Nov 30, 2016
Merged

Detect changes to inner modules #143

merged 2 commits into from
Nov 30, 2016

Commits on Nov 30, 2016

  1. Exploring inner modules for binary incompatibilities. Fix lightbend-l… 

    …abs#127

The former implementation of PackageInfo#accessibleClasses expects that for any
module `Foo` compiled by scalac, both `Foo.class` and `Foo$.class` classfiles
are produced. Because `Foo$.class` and `Foo.class` are essentially mirrors, and
users never access directly `Foo$.class`, MiMa only traverses the `Foo.class`. This
works well for top-level modules, but it breaks for inner modules, because no
mirror class is created for inner modules (only the module class is created).

The fix consist in treating inner modules differently, hence making sure inner
modules are part of the set returned by PackageInfo#accessibleClasses.
    @dotta @szeiger
    dotta authored and szeiger committed Nov 30, 2016
    Configuration menu
    Copy the full SHA
    f3f8939 View commit details
    Browse the repository at this point in the history

  2. Use InnerClasses attribute to find all reachable classes

    @szeiger
    szeiger committed Nov 30, 2016
    Configuration menu
    Copy the full SHA
    615b35a View commit details
    Browse the repository at this point in the history