Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed overloads are missing, not incompatible #362

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Removed overloads are missing, not incompatible #362

merged 2 commits into from
Jul 30, 2019

Commits on Jul 29, 2019

  1. Add class-removed-method-overload-ko, w/ bad msg

    @dwijnand
    dwijnand committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    ebebf46 View commit details
    Browse the repository at this point in the history

  2. Removed overloads are missing, not incompatible 

    Previously the method checker didn't take overloading into account,
which means that the loss of a method overloading (which includes the
loss of a static forwarder methods, when upgrading from Scala 2.12.7 to
2.12.8+) was reported as an "incompatible method type" problem or a
"incompatible result type" problem.

With this change these are now correctly reported as "direct missing
method" problems.
    @dwijnand
    dwijnand committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    b4ceddc View commit details
    Browse the repository at this point in the history