Adding an abstract method is a binary compatible evolution. Fix #69

reporter/functional-tests/src/test/java-adding-abstract-method-to-class-ok/v1/A.java

@@ -0,0 +1 @@
+public abstract class A {}

reporter/functional-tests/src/test/java-adding-abstract-method-to-class-ok/v1/B.java

@@ -0,0 +1 @@
+public class B extends A {}

reporter/functional-tests/src/test/java-adding-abstract-method-to-class-ok/v2/A.java

@@ -0,0 +1,3 @@
+public abstract class A {
+   public abstract String foo();
+}

reporter/functional-tests/src/test/java-adding-abstract-method-to-class-ok/v2/B.java

@@ -0,0 +1,5 @@
+public class B extends A {
+  public String foo() {
+  	return null;
+  }
+}

reporter/functional-tests/src/test/java-adding-method-to-interface-implemented-by-a-class-ok/v1/A.java

@@ -0,0 +1 @@
+public interface A {}

reporter/functional-tests/src/test/java-adding-method-to-interface-implemented-by-a-class-ok/v1/B.java

@@ -0,0 +1 @@
+public class B implements A {}

reporter/functional-tests/src/test/java-adding-method-to-interface-implemented-by-a-class-ok/v2/A.java

@@ -0,0 +1,3 @@
+public interface A {
+   public String foo();
+}

reporter/functional-tests/src/test/java-adding-method-to-interface-implemented-by-a-class-ok/v2/B.java

@@ -0,0 +1,5 @@
+public class B implements A {
+  public String foo() {
+  	return null;
+  }
+}

reporter/functional-tests/src/test/java8-add-default-method/v1/A.java

@@ -0,0 +1 @@
+public interface A {}

reporter/functional-tests/src/test/java8-add-default-method/v2/A.java

@@ -0,0 +1,5 @@
+public interface A {
+   public default String foo() {
+      return null;
+    }
+}

reporter/functional-tests/src/test/trait-abstract-val-become-concrete-ok/problems.txt

@@ -1 +0,0 @@
-synthetic method A$_setter_$foo_=(Int)Unit in trait A does not have a correspondent in old version

reporter/functional-tests/src/test/trait-moving-methods-nok/problems.txt

@@ -1,2 +1 @@
-method foo()Int in trait A does not have a correspondent in new version
-method foo()Int in trait B does not have a correspondent in old version
+method foo()Int in trait A does not have a correspondent in new version

reporter/functional-tests/src/test/trait-moving-methods-nok/v1/A.scala

@@ -2,7 +2,3 @@ trait A {
   def bar = 2
   def foo = 2
 }
-
-trait B
-
-class C extends A with B

reporter/functional-tests/src/test/trait-moving-methods-nok/v2/A.scala

@@ -1,9 +1,3 @@
 trait A {
   def bar = 2
-}
-
-trait B {
-  def foo = 2
-}
-
-class C extends A with B
+}

reporter/src/main/scala/com/typesafe/tools/mima/lib/analyze/Analyzer.scala

@@ -78,18 +78,14 @@ private[analyze] class ClassAnalyzer extends Analyzer {
   override def analyzeNewClassMethods(oldclazz: ClassInfo, newclazz: ClassInfo): List[Problem] = {
     for (newAbstrMeth <- newclazz.deferredMethods) yield {
       oldclazz.lookupMethods(newAbstrMeth.bytecodeName).find(_.sig == newAbstrMeth.sig) match {
-        case None =>
-          val p = MissingMethodProblem(newAbstrMeth)
-          p.affectedVersion = Problem.ClassVersion.Old
-          Some(p)
         case Some(found) =>
-          if(found.isConcrete) {
-        	val p = AbstractMethodProblem(newAbstrMeth)
-        	p.affectedVersion = Problem.ClassVersion.Old
-        	Some(p)
-          }
-          else
-        	None
+          if (found.isConcrete) {
+            val p = AbstractMethodProblem(newAbstrMeth)
+            p.affectedVersion = Problem.ClassVersion.Old
+            Some(p)
+          } else
+            None
+        case _ => None
       }
     }
   }
@@ -103,33 +99,19 @@ private[analyze] class TraitAnalyzer extends Analyzer {
   protected val methodChecker = new TraitMethodChecker
 
   override def analyzeNewClassMethods(oldclazz: ClassInfo, newclazz: ClassInfo): List[Problem] = {
-    val res = collection.mutable.ListBuffer.empty[Problem]
-
-    for (newmeth <- newclazz.concreteMethods if !oldclazz.hasStaticImpl(newmeth)) {
-      if (!oldclazz.lookupMethods(newmeth.bytecodeName).exists(_.sig == newmeth.sig)) {
-        // this means that the method is brand new and therefore the implementation
-        // has to be injected
-        val problem = MissingMethodProblem(newmeth)
-        problem.affectedVersion = Problem.ClassVersion.Old
-        res += problem
-      }
+    for {
+      newmeth <- newclazz.concreteMethods if !oldclazz.hasStaticImpl(newmeth)
+      if !oldclazz.lookupMethods(newmeth.bytecodeName).exists(_.sig == newmeth.sig)
       // else a static implementation for the same method existed already, therefore
       // class that mixed-in the trait already have a forwarder to the implementation
       // class. Mind that, despite no binary incompatibility arises, program's
       // semantic may be severely affected.
+    } yield {
+      // this means that the method is brand new and therefore the implementation
+      // has to be injected
+      val problem = MissingMethodProblem(newmeth)
+      problem.affectedVersion = Problem.ClassVersion.Old
+      problem
     }
-
-    for (newmeth <- newclazz.deferredMethods) {
-      val oldmeths = oldclazz.lookupMethods(newmeth.bytecodeName)
-      oldmeths find (_.sig == newmeth.sig) match {
-        case Some(oldmeth) => ()
-        case _ =>
-          val problem = MissingMethodProblem(newmeth)
-          problem.affectedVersion = Problem.ClassVersion.Old
-          res += problem
-      }
-    }
-
-    res.toList
   }
 }