Filter problems in mimaFindBinaryIssues

[julienrf]

Currently, mimaFindBinaryIssues does not apply the problem filters. This means that the output of mimaFindBinaryIssues may be inconsistent with what is reported by mimaReportBinaryIssues (ie, the former may be non-empty although the latter would not report any issue). Is that intentional?

In sbt-version-policy we have to re-implement the problem filtering because of that behavior.

Note that applying the filters in mimaFindBinaryIssues would require more changes than this commit: the code that implements the reporting part would have to be updated accordingly (currently, it takes the filters as parameters, and it prints the number of problems that have been filters out).

Another way to reduce the code duplication between sbt-version-policy and mima would be to make the method ProblemReporting.isReported public.

How would you like to proceed? Apply the filtering in mimaFindBinaryIssues, make ProblemReporting.isReported public, or do nothing?

[dwijnand]

I don't think the right choice is changing the behaviour of mimaFindBinaryIssues. ProblemReporting.isReported seems simple enough to make public, so let's go with that.

[julienrf]

Thank you for the review. I am not working on this problem anymore, but if someone is interested in taking it over from here, please feel free to do so!