in build, set name of root project #94
Conversation
allowing it to default to "root" leads to this error in the community build, after extraction: [error] Fatal: multiple projects have the same artifacts visible in the same space. [error] root#root from scala-records and mima, both visible in space "default" perhaps dbuild ought to notice that `publish` and `publishLocal` are `()` in the root project, but it doesn't (not dbuild 0.9.1 anyway, I don't know about later versions). and as far as I can see, setting the name is harmless.
|
so dbuild is building mima? I guess it's because you want to use master (or a branch). Anyhow, I don't see how setting the name for the root's project would cause issues, so this lgtm. |
in build, set name of root project
I just like to make sure important projects like MiMa are included in the Scala community build, mainly as a guard against Scala regressions. (I haven't submitted a PR with the addition yet because this isn't the only fix I need to make.) In the context of the community build, the MiMa we build won't actually get used by the other projects, since the other projects get their MiMa via the sbt plugin, and we no longer build sbt plugins or their dependencies as part of the community build. So the value isn't as great as it theoretically could be, but it still seems worthwhile to me just to make sure MiMa builds and its tests pass (under the Scala version the community build is testing). |
how come, if I may ask? |
the main purpose of the community build is to guard against regressions in Scala. but sbt 0.13 plugins live in Scala 2.10 world and no further 2.10.x releases are planned. plus, no longer building the plugins makes the build faster and prevents a lot of maintenance headaches from ever arising. (the community build is a headache factory, so we have to make a lot of these sorts of cost/benefit decisions to keep it from consuming too much of our time.) (reference: @adriaanm's scala/community-build@ecae16d — a skim through this should give some idea of the number and variety of headaches that can arise) |
|
I see, thanks. |
|
Thanks @SethTisue for the detailed answer! |
allowing it to default to "root" leads to this error in the
community build, after extraction:
perhaps dbuild ought to notice that
publishandpublishLocalare()in the root project, but it doesn't (not dbuild 0.9.1 anyway, Idon't know about later versions). and as far as I can see, setting
the name is harmless.
review by @dotta