Using Committable in place of CommittableOffset

[blublinsky]

Is your feature request related to a problem? Please describe.
Currently flowWithOffsetContext[T] is accepting CommittableOffset, which prevents one from introduction internal events (for example, timer) and still have input events commitable

Is your feature request related to a specific runtime of cloudflow or applicable for all runtimes?
This is only relevant for Akka Streams

Describe the solution you'd like
I would like flowWithOffsetContext[T] to accept Committable, so that for internal events I can use (v, CommittableOffsetBatch.empty) and I can merge internal and external events

Describe alternatives you've considered
The only alternative currently is to use plainSink, which means that kafka events are not committed and restartability of streamlet does not work

Additional context
None

[osleonard]

Is someone working on this ?

[olofwalker]

@osleonard I think @RayRoestenburg completed work on this but never closed the ticket.

[RayRoestenburg]

Yes, it is already in master, docs are getting updated now

On Fri, 7 Feb 2020 at 19:02, Akinmolayan Olushola ***@***.***> wrote: Is someone working on this ? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#96?email_source=notifications&email_token=AABGGCNGBCDWAUNNYSYUNO3RBWO3NA5CNFSM4J6YDTZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELD7TOI#issuecomment-583530937>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGGCMT7ZX7LEGPKYZH4T3RBWO3NANCNFSM4J6YDTZQ> .

-- *Principal Engineer, Lightbend, Inc.* ray@lightbend.com <raymond@lightbend.com> @RayRoestenburg <https://twitter.com/RayRoestenburg> <https://www.lightbend.com/>

[RayRoestenburg]

Correct

On Fri, 7 Feb 2020 at 19:04, Robert Walker ***@***.***> wrote: @osleonard <https://github.com/osleonard> I think @RayRoestenburg <https://github.com/RayRoestenburg> completed work on this but never closed the ticket. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#96?email_source=notifications&email_token=AABGGCKRGVY3CL2V6KBDWYLRBWPDXA5CNFSM4J6YDTZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELD73EQ#issuecomment-583531922>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGGCNEW4FCYDVQE7DPSFTRBWPDXANCNFSM4J6YDTZQ> .

-- *Principal Engineer, Lightbend, Inc.* ray@lightbend.com <raymond@lightbend.com> @RayRoestenburg <https://twitter.com/RayRoestenburg> <https://www.lightbend.com/>

[osleonard]

Haa ok will look for something else to pick in the backlog :)

[RayRoestenburg]

Cool! Thanks

On Fri, 7 Feb 2020 at 19:05, Akinmolayan Olushola ***@***.***> wrote: Haa ok will look for something else to pick in the backlog :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#96?email_source=notifications&email_token=AABGGCMP6YMWQIW4BBRTEVTRBWPHVA5CNFSM4J6YDTZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELD76XI#issuecomment-583532381>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGGCNBWLTSBZQWTXGOK3DRBWPHVANCNFSM4J6YDTZQ> .

-- *Principal Engineer, Lightbend, Inc.* ray@lightbend.com <raymond@lightbend.com> @RayRoestenburg <https://twitter.com/RayRoestenburg> <https://www.lightbend.com/>

[RayRoestenburg]

This issue is linked to #100