Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Configurable readiness and liveness probes in helm chart #145

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

chelomontilla
Copy link
Contributor

@chelomontilla chelomontilla commented Aug 3, 2020

fixes #144 Add variables to configure the liveness and readiness probes delay and timeouts in the helm chart

@lightbend-cla-validator
Copy link

Hi @chelomontilla,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

Copy link
Owner

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo changed the title configurable readiness and liveness probes in helm chart Configurable readiness and liveness probes in helm chart Aug 4, 2020
@seglo seglo merged commit 8ca06d7 into seglo:master Aug 4, 2020
@seglo
Copy link
Owner

seglo commented Aug 4, 2020

@chelomontilla Thanks for raising the issue and creating the PR!

@chelomontilla chelomontilla deleted the helm--deployment-probes branch August 6, 2020 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to configure livenessProbe and readinessProbe
3 participants