Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Fix Helm Chart: Whitespace in Deployment.yaml #77

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

abhishekjiitr
Copy link
Contributor

Extra whitespace is being removed while templating serviceAccountName in file charts/kafka-lag-exporter/templates/040-Deployment.yaml

This leads to the following error when templating/installing the helm chart with watchers.strimzi or serviceAccount.create enabled:

Error: UPGRADE FAILED: YAML parse error on kafka-lag-exporter/templates/040-Deployment.yaml: error converting YAML to JSON: yaml: line 21: mapping values are not allowed in this context

This happens because it is being templated as:

spec: serviceAccountName: {{ include "kafka-lag-exporter.fullname" . }}-serviceaccount

instead of

spec: 
  serviceAccountName: {{ include "kafka-lag-exporter.fullname" . }}-serviceaccount

@lightbend-cla-validator

Hi @abhishekjiitr,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@abhishekjiitr abhishekjiitr changed the title Fix Helm Chart: Deployment.yaml Fix Helm Chart: Whitespace in Deployment.yaml Sep 23, 2019
@seglo
Copy link
Owner

seglo commented Sep 23, 2019

Thank you @abhishekjiitr . I've spotted another regression issue with strimzi auto discovery as well. I'm working on a fix for that and then I'll merge both and cut a new release.

@seglo seglo merged commit 2f8a46d into seglo:master Sep 23, 2019
@seglo
Copy link
Owner

seglo commented Sep 23, 2019

@abhishekjiitr I've released 0.5.3. LMK if you have any issues with it.

@abhishekjiitr abhishekjiitr deleted the patch-1 branch September 23, 2019 19:03
@abhishekjiitr
Copy link
Contributor Author

Thanks @seglo ! Is there any official channel / community for kafka-lag-exporter, where these things can be discussed? It will be really helpful for the people using it.

@seglo
Copy link
Owner

seglo commented Sep 23, 2019

@abhishekjiitr There's no other community support channel other than GitHub issues at this time. Are you thinking some kind of live chat, mailing list, or something else?

@abhishekjiitr
Copy link
Contributor Author

abhishekjiitr commented Sep 24, 2019

@seglo, Anything could work, just a place where people can discuss stuff, I personally prefer Slack / Gitter Channel.

anbarasantr pushed a commit to anbarasantr/kafka-lag-exporter that referenced this pull request Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants