Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

StreamsBuilderS.globalTable misses overload with Consumed[K, V] as parameter #31

Closed
jeroenr opened this issue Jan 8, 2018 · 2 comments
Assignees

Comments

@jeroenr
Copy link

jeroenr commented Jan 8, 2018

First of all, thanks a lot for this library. It makes my code look much cleaner.

I did notice that StreamsBuilderS.globalTable has no overload where I can pass a customer Consumed[K, V] parameter as in

(new StreamsBuilderS).globalTable("my_table", Consumed.`with`(new MyKeySerde, new MyValueSerde))

My current workaround is to use the inner StreamsBuilder like:

(new StreamsBuilderS).inner.globalTable("my_table", Consumed.`with`(new MyKeySerde, new MyValueSerde))

Is there any specific reason why StreamsBuilderS.globalTable doesn't have this overload?

@debasishg
Copy link
Contributor

Glad to hear that it makes your code cleaner. Regarding StreamsBuilderS.globalTable we will add the overloads. No specific reason NOT to have them.

@debasishg debasishg self-assigned this Jan 8, 2018
debasishg added a commit that referenced this issue Jan 10, 2018
@debasishg
Copy link
Contributor

Fixed on develop branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants