feat(spring-sdk): provide access to current state in views #1092

efgpinto · 2022-09-02T14:43:11Z

References #1091

This MR:

adds access to current state in the context of a view
adds IT tests with valueentity, view and transformed view

sdk/java-sdk/src/main/java/kalix/javasdk/view/View.java

efgpinto · 2022-09-08T23:08:13Z

Updated now to allow for passing the stateby param and ready for new review. Some tests failing with the Jackson parameters issue, will revisit tomorrow.

sdk/spring-sdk/src/it/java/com/example/wiring/SpringSdkWiringIntegrationTest.java

octonato

LGTM

I did a quick review. Good to have another ✅ before merging

samples/spring-wiring-tests/src/main/java/wiring/view/UserWithVersion.java

octonato · 2022-09-09T13:16:37Z

sdk/spring-sdk/src/main/scala/kalix/springsdk/impl/reflection/KalixMethod.scala

@@ -95,9 +95,9 @@ case class VirtualServiceMethod(component: Class[_], methodName: String, inputTy
 * Build from methods annotated with @Subscription. Those methods are not annotated with Spring REST annotations, but
 * they become a REST method at the end.
 */
-case class RestServiceMethod(javaMethod: Method) extends AnyServiceMethod {
+case class RestServiceMethod(javaMethod: Method, inputTypeParamIndex: Int = 0) extends AnyServiceMethod {


what was that? :D

I think I added one h to much

It was intended to be: Aha!

Like in: Aha! Now we have a solution for skipping the first arg and extracting the next one.

Aha! Now I get it! :D

sdk/spring-sdk/src/it/java/com/example/wiring/SpringSdkWiringIntegrationTest.java

…ntegrationTest.java Co-authored-by: Renato Cavalcanti <renato@cavalcanti.be>

octonato · 2022-09-09T14:45:36Z

.circleci/config.yml

-  sample-spring-wiring-tests:
-    machine:
-      image: ubuntu-2004:202201-02
-    steps:
-      - checkout-and-merge-to-main
-      - setup_sbt
-      - restore_deps_cache
-      # note: `copy-from-workspace` requires `publish-local` to be run first as declared in workflow section below
-      - copy-from-workspace
-      - set-sdk-version
-      - run:
-          name: Spring SDK wiring tests
-          command: |
-            cd samples/spring-wiring-tests
-            echo "Running mvn with SDK version: '$SDK_VERSION'"
-            # no testing for now, only 'compile'
-            mvn -Dkalix-sdk.version=$SDK_VERSION verify -Pit


franciscolopezsancho

LGTM

franciscolopezsancho · 2022-09-09T14:38:07Z

sdk/spring-sdk/src/main/scala/kalix/springsdk/impl/view/ReflectiveViewRouter.scala

@@ -17,12 +17,15 @@
 package kalix.springsdk.impl.view

 import com.google.protobuf.any.{ Any => ScalaPbAny }
-import kalix.javasdk.Metadata
+import kalix.javasdk.{ JsonSupport, Metadata }


two lines, one line? :)

not sure what you mean :S would you elaborate, please?

ah, you mean two separate lines?

I mean, I guess this should be automatic.. otherwise it's a pain.. I think this is fine if no checks are triggered. I checked that we have other instances in the code of using this format.

sdk/spring-sdk/src/test/java/kalix/springsdk/testmodels/view/ViewTestModels.java

sdk/spring-sdk/src/test/scala/kalix/springsdk/impl/ViewDescriptorFactorySpec.scala

sdk/spring-sdk/src/main/scala/kalix/springsdk/impl/ViewDescriptorFactory.scala

sdk/spring-sdk/src/main/scala/kalix/springsdk/impl/view/ReflectiveViewRouter.scala

efgpinto changed the title ~~feat(sprind-sdk): provide access to current state in views~~ feat(spring-sdk): provide access to current state in views Sep 2, 2022

github-actions bot added java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team scala-sdk-protobuf java-sdk labels Sep 2, 2022

efgpinto changed the base branch from main to spring-sdk September 2, 2022 14:43

efgpinto force-pushed the add_current_state_views branch from 8c6cdeb to c7e0cd9 Compare September 6, 2022 10:06

github-actions bot removed the scala-sdk-protobuf label Sep 6, 2022

efgpinto force-pushed the add_current_state_views branch from c7e0cd9 to 497baff Compare September 6, 2022 10:11

johanandren reviewed Sep 6, 2022

View reviewed changes

sdk/java-sdk/src/main/java/kalix/javasdk/view/View.java Outdated Show resolved Hide resolved

efgpinto force-pushed the add_current_state_views branch 4 times, most recently from f853ac0 to a76f6e0 Compare September 8, 2022 22:57

efgpinto marked this pull request as ready for review September 8, 2022 23:07

efgpinto force-pushed the add_current_state_views branch 3 times, most recently from 591ff07 to d7a4a02 Compare September 9, 2022 10:56

efgpinto commented Sep 9, 2022

View reviewed changes

sdk/spring-sdk/src/it/java/com/example/wiring/SpringSdkWiringIntegrationTest.java Outdated Show resolved Hide resolved

efgpinto force-pushed the add_current_state_views branch 2 times, most recently from 834a958 to dada7fa Compare September 9, 2022 12:29

octonato approved these changes Sep 9, 2022

View reviewed changes

octonato reviewed Sep 9, 2022

View reviewed changes

sdk/spring-sdk/src/it/java/com/example/wiring/SpringSdkWiringIntegrationTest.java Outdated Show resolved Hide resolved

efgpinto and others added 3 commits September 9, 2022 15:12

feat(spring-sdk): provide access to currentState on views

6e93dde

Update sdk/spring-sdk/src/it/java/com/example/wiring/SpringSdkWiringI…

d227e5e

…ntegrationTest.java Co-authored-by: Renato Cavalcanti <renato@cavalcanti.be>

removing spring-wiring-tests

fc19aa9

efgpinto force-pushed the add_current_state_views branch from 5c720fd to fc19aa9 Compare September 9, 2022 14:13

octonato reviewed Sep 9, 2022

View reviewed changes

franciscolopezsancho reviewed Sep 9, 2022

View reviewed changes

format importing

a62b815

efgpinto merged commit b6d3754 into lightbend:spring-sdk Sep 9, 2022

efgpinto deleted the add_current_state_views branch September 9, 2022 15:16

This was referenced Sep 9, 2022

spring-sdk: view need a currentState method #1091

Closed

chore: refactor on error message for views #1110

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(spring-sdk): provide access to current state in views #1092

feat(spring-sdk): provide access to current state in views #1092

efgpinto commented Sep 2, 2022 •

edited

efgpinto commented Sep 8, 2022 •

edited

octonato left a comment

octonato Sep 9, 2022

efgpinto Sep 9, 2022

octonato Sep 9, 2022

efgpinto Sep 9, 2022

octonato Sep 9, 2022

franciscolopezsancho left a comment

franciscolopezsancho Sep 9, 2022

efgpinto Sep 9, 2022 •

edited

efgpinto Sep 9, 2022

feat(spring-sdk): provide access to current state in views #1092

feat(spring-sdk): provide access to current state in views #1092

Conversation

efgpinto commented Sep 2, 2022 • edited

efgpinto commented Sep 8, 2022 • edited

octonato left a comment

Choose a reason for hiding this comment

octonato Sep 9, 2022

Choose a reason for hiding this comment

efgpinto Sep 9, 2022

Choose a reason for hiding this comment

octonato Sep 9, 2022

Choose a reason for hiding this comment

efgpinto Sep 9, 2022

Choose a reason for hiding this comment

octonato Sep 9, 2022

Choose a reason for hiding this comment

franciscolopezsancho left a comment

Choose a reason for hiding this comment

franciscolopezsancho Sep 9, 2022

Choose a reason for hiding this comment

efgpinto Sep 9, 2022 • edited

Choose a reason for hiding this comment

efgpinto Sep 9, 2022

Choose a reason for hiding this comment

efgpinto commented Sep 2, 2022 •

edited

efgpinto commented Sep 8, 2022 •

edited

efgpinto Sep 9, 2022 •

edited