Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: update akka-grpc to 2.0.0 #15

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Conversation

pvlugter
Copy link
Member

@pvlugter pvlugter commented Jun 4, 2021

I haven't bumped the akka-grpc version in the samples. They fail to build with the java-sdk on beta.10 and akka-grpc plugin on 2.0.0. While it seems fine with newer java-sdk (built against akka-grpc 2.0.0) and the older akka-grpc plugin — and this should be tested in CI as well.

So probably best to wait with bumping the samples until next java-sdk release, and bump both versions together. And also do this in the maven archetypes.

Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems good.

So this means the examples in this repo are not built against the SDK in this repo, but against the previously-released SDK? Perhaps we should update our CI setup so that the examples are ran against the 'current' version of the SDK? That would give us a better opportunity to test changes to the SDK (though also mean that if we want to publish a change to the samples without publishing the SDK, we'd need to come up with a workflow for that, e.g. backporting those to some other branch)

project/Dependencies.scala Outdated Show resolved Hide resolved
@octonato
Copy link
Member

octonato commented Jun 4, 2021

@raboof we are starting to build the samples with the current (in this branch) SDK version.
You can see it here: https://github.com/lightbend/akkaserverless-java-sdk/blob/main/.circleci/config.yml#L147-L159

The goal is to that for all the samples.

@octonato
Copy link
Member

octonato commented Jun 4, 2021

@raboof, I created an issue #17 to discuss the topic you raised here related with versioning and publishing of the samples.

Co-authored-by: Arnout Engelen <arnout@engelen.eu>
@octonato
Copy link
Member

octonato commented Jun 4, 2021

@pvlugter, I applied Arnout's suggestion to the branch so we can rollout this sooner.

@raboof
Copy link
Contributor

raboof commented Jun 4, 2021

we are starting to build the samples with the current (in this branch) SDK version.

Ah, that also explains why the integration tests fail on CI then ;). So perhaps we should update akka-grpc in the examples after all, even though it means you will always have to run them with -Dakkaserverless-sdk.version?

project/Dependencies.scala Outdated Show resolved Hide resolved
@pvlugter
Copy link
Member Author

pvlugter commented Jun 8, 2021

CI was failing with maven central download hiccups.

Yes, so CI does run the samples against the current development version. But the samples otherwise have the last release. The current SDK works with the samples on akka-grpc 1.1.1, but not the older beta.10 SDK with akka-grpc 2.0.0. So we can wait with updating the akka-grpc version in the archetypes and the samples until next SDK release, so that the default builds also work for now.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru
Copy link
Member

ennru commented Jun 8, 2021

But why does this succeed when the Maven samples are not updated to use Akka gRPC 2.0.0 for the integration test client?
We need to update the version in the Maven archetypes to create a working setup:
https://github.com/lightbend/akkaserverless-maven-java/pull/106

@pvlugter
Copy link
Member Author

pvlugter commented Jun 8, 2021

But why does this succeed when the Maven samples are not updated to use Akka gRPC 2.0.0 for the integration test client?

I probably wasn't clear enough. The combination that does not work is the SDK on old Akka gRPC 1.1.1 and the project protobuf generation on new Akka gRPC 2.0.0 — haven't looked closely, but generation from new plugin with old runtime dependency is likely the problem. So the samples when on old SDK (beta.10) will not work with the Akka gRPC update. While a new SDK (which will pull Akka gRPC 2.0.0 runtime) will still work with the old Akka gRPC 1.1.1 generation. And so the CI sample builds (which overrides to the development version) will work either way. Overriding the runtime dependency could also work for running new Akka gRPC plugin with the old SDK.

My suggestion: first update Akka gRPC to 2.0.0 for the SDK (this PR currently). Release a new SDK version, which should work with either plugin in projects. Then update Akka gRPC in archetypes and samples.

@pvlugter pvlugter merged commit 0e87eff into lightbend:main Jun 9, 2021
@pvlugter pvlugter deleted the akka-grpc-2.0.0 branch June 9, 2021 22:20
octonato pushed a commit that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants