Non-reflection eventsourced entity handler #163
Conversation
raboof
force-pushed
the
wip-non-reflection-event-sourced-take-3
branch
2 times, most recently
from
d96abf8
to
a3d8e59
Compare
raboof
force-pushed
the
wip-non-reflection-event-sourced-take-3
branch
from
a3d8e59
to
2de27a8
Compare
rebase mistake
| // ugh, remove | ||
| var snapshotEvery = 0 |
There was a problem hiding this comment.
ugh, remove? why?
If it stays, should be private var, no?
| final protected def setState(newState: S): Unit = | ||
| state = Some(newState) |
There was a problem hiding this comment.
Since setState is called with the return of an event handler, we can expect users to return null.
| final protected def setState(newState: S): Unit = | |
| state = Some(newState) | |
| final protected def setState(newState: S): Unit = | |
| state = Option(newState) |
| require(emptyState != null, "Entity empty state is not allowed to be null") | ||
| state = Some(emptyState) |
There was a problem hiding this comment.
I think it should be allowed to be null. I would expect java developers to define their emptyState with null.
There was a problem hiding this comment.
I see that this comes from previous code and only moved to here. Still, I do think that the user can always define its state as null and at any point of its lifecycle.
There was a problem hiding this comment.
I think I agree - but let's keep it for a different PR given this is the same as before?
There was a problem hiding this comment.
fine, I will create an issue about this
| currentSequence += 1 | ||
| shouldSnapshot = shouldSnapshot || (snapshotEvery > 0 && currentSequence % snapshotEvery == 0) | ||
| } | ||
| // FIXME currently snapshotting final state after applying all events even if trigger was mid-event stream? |
There was a problem hiding this comment.
I think this is ok since snapshotting is just an optimization. We don't need to be precise about what was exactly the event that reached the threshold
| val endState = stateOrEmpty() | ||
| val snapshot = | ||
| if (shouldSnapshot) Option(endState) |
There was a problem hiding this comment.
If we accept that the state can be null, then we don't need to call stateOrEmpty and we can just return state since it's already an Option.
* Handcoded entity command and event routing, refactored wrapping handler * Throw EntityException when command type not found * Fix import rebase mistake Co-authored-by: Johan Andrén <johan@markatta.com>
Based on #150 but excluding the move of the deserialization from the
generated code for now: we might still want to do that, but I'm not
entirely confident about it yet - let's see how JSON support and
testkit re-use pan out.