chore: update scala version #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
efgpinto
approved these changes
Apr 18, 2024
| @@ -66,7 +66,8 @@ object HttpEndpointMethodDefinition { | |||
| name = "ANY", | |||
| safe = false, | |||
| idempotent = false, | |||
| requestEntityAcceptance = RequestEntityAcceptance.Tolerated) | |||
| requestEntityAcceptance = RequestEntityAcceptance.Tolerated, | |||
| contentLengthAllowed = true) | |||
There was a problem hiding this comment.
Just curious, but why? What's the background here?
There was a problem hiding this comment.
It also came as a surprise to me.
I updated the scala version to 2.13.13 and now we get a deprecation error. What I suspect is that scalac now also detect methods deprecated with Java's Deprecated annotation. And that is the case of this method.
It's a method from akka http, written in Scala, but deprecated with Java's annotation. It was not detected before as warning/error before.
About using true instead of false, according to the PR in akka http that deprecated this method, length should be 0 depending on the status code.
Actually, what I did here is not good. I will update it. It should not simply use true, but we need to pass a function that decide it based on the status code. Hold on, I will update it.
octonato
force-pushed
the
octonato/update-scala-version
branch
from
0873c04
to
ed01f31
Compare
octonato
force-pushed
the
octonato/update-scala-version
branch
from
ed01f31
to
4c83fb9
Compare
octonato
added a commit
that referenced
this pull request
Apr 19, 2024
* chore: update scala version * remove deprecated api usage * use status code predicate
octonato
added a commit
that referenced
this pull request
Apr 30, 2024
* feat: ComponentClient tracing (#2063) * feat: ComponentClient tracing * feat: component to component tracing spring * move KalixClient to impl package * formatting * re-added full imports * Apply suggestions from code review Co-authored-by: Eduardo Pinto <eduardo.pinto@lightbend.com> * Update sdk/java-sdk-spring/src/test/java/kalix/javasdk/client/ComponentClientTest.java Co-authored-by: Eduardo Pinto <eduardo.pinto@lightbend.com> * renamed method and added extra comments * remove possibility to inject KalixClient * remove direct dependency on KalixClient * use FQCN when failing wiring --------- Co-authored-by: Francisco Lopez-Sancho <franciscolopezsancho@gmail.com> Co-authored-by: Eduardo Pinto <eduardo.pinto@lightbend.com> * Update LICENSE to BSL (#2054) * Update LICENSE to BSL * Date reminder --------- Co-authored-by: Enno Runne <458526+ennru@users.noreply.github.com> * chore: bump akka libs to latest (#2067) * chore: bump akka libs to latest * remove akka-http2-support deps * used scalaPb instead of akka-grpc * add akka resolvers to scala samples * add akka resolvers to mvn samples and archetypes * align protoc version * chore: disciplined compiler settings and deprecation removal (#2072) * chore: remove warnings and deprecated APIs * remove EntityKey, EntityType and GenerateEntityKey * remove KalixTestKit.getTopic * remove KalixTestKit.getGrpcClientSettings * remove withPassivationStrategy * remove Auto-application to () * remove usage of Akka deprecated APIs * fixing scaladoc links * silence warnings from generated code * fix GenerateMojo call * remove unused imports * fix link to OutgoingMessagesImpl#DefaultTimeout * BSL license in project settings (#2076) * chore: remove unused code (#2079) * chore: use java 21 in samples and templates (#2078) * chore: use java 21 in samples and templates * move to java.version property * upgrade Spring versions * use jdk21 in CI * update scala version in samples * fix spring client - bump deps * using jdk21 in proto samples * align docker images * chore: file headers (#2083) * Publish to Cloudsmith (from GH workflow) Take 2 (#2082) * chore: bump sbt version to 1.9.9 (#2084) * chore: bump sbt version to 1.9.9 * add akka resolver to tracing sample * Publishing fixes (round 1) (#2087) * Publishing from Maven (#2091) * Publishing to Maven (Take 2) (#2092) * Publishing to Maven (Take 3) (#2093) * Publish Maven plugin (Take 4) (#2094) * Publish Maven plugin (Take 5) (#2096) * bump: current GH actions versions (#2097) * Extract sbt props in client mode (#2101) * Token to use git commands for docs publishing (#2100) * Publish sbt plugin (filter duplicate) (#2095) * bump: GH setup-action, upload/download actions (#2103) * chore: update scala version (#2098) * chore: update scala version * remove deprecated api usage * use status code predicate * SDK version bump creation (transfer from Circle) (#2104) * Publish Maven plugin (Take 6) (#2102) * Publish Maven plugin (Take 6) * Publish Maven things to Sonatype * Maven publishing (Take 7) (#2105) * Tests in CI: use local docker compose (#2106) * Remove references to CircleCI (#2107) * Maven publishing (Take 7) (#2108) * Extracting the SDK version (#2109) * Extracting the SDK version (Take 2) (#2110) * Determine SDK version (Take 3) (#2111) * Extracting the SDK version (Take 4) (#2112) * Repositories in archetypes, debug publishing (#2113) * Kalix.io Sonatype publishing (#2114) * chore: remove unnecessary resolvers (#2115) * Docs publishing (on tag) (#2116) * feat: kalix-spring-parent pom (#2117) * feat: parent pom for java protobuf (#2118) * feat: parent pom for java protobuf * update kalix-sdk.version in parent poms * fix: kalix-spring-boot-parent publishing (#2119) * fix: isolate parent pom plugins (#2120) * fix: remove bogus plugin re-declaration (#2121) * fix: enable all parent pom plugins (#2122) * bump: Jackson 2.15.4 (aligns with Akka 2.9) (#2126) * feat: expose underlying Akka version (#2125) * feat: expose underlying Akka version * add to BuildInfo in codegenScala * bump: setup-java action 4.2.1 (#2124) * feat: expose underlying Akka version correctly (#2128) * feat: ease build for multi-platform images (#2123) * fix: correctly configure spring-boot plugin (#2127) --------- Co-authored-by: Francisco Lopez-Sancho <franciscolopezsancho@gmail.com> Co-authored-by: Eduardo Pinto <eduardo.pinto@lightbend.com> Co-authored-by: Justin Pihony <justin.pihony@gmail.com> Co-authored-by: Enno Runne <458526+ennru@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.